Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update-sponsors: don't require admin token. #13820

Merged
merged 2 commits into from
Sep 8, 2022
Merged

update-sponsors: don't require admin token. #13820

merged 2 commits into from
Sep 8, 2022

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Sep 7, 2022 •
edited
Loading

Instead, use a different API to query these with a lower scope and use it with GitHub Actions.

We have an issue that affects our ability to display some organisations here that I've reported internally to the sponsors team at GitHub.

@BrewTestBot
Copy link
Member

Review period will end on 2022-09-08 at 14:15:49 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 7, 2022
@MikeMcQuaid
update-sponsors: don't require admin token.
bc295f7 
Instead, use a different API to query these with a lower scope.

This should be usable by GitHub Actions.
Rylan12
Rylan12 approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know anything about graphql but looks good as long as it works!

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Sep 8, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 8, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit 04dfb9d into Homebrew:master Sep 8, 2022
@MikeMcQuaid MikeMcQuaid deleted the update-update-sponsors branch September 8, 2022 10:14
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 9, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@Rylan12 Rylan12 Rylan12 approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikeMcQuaid @BrewTestBot @Rylan12